[wp-trac] [WordPress Trac] #27359: Color Picker Missing From WordPress 3.9
WordPress Trac
noreply at wordpress.org
Sun Apr 20 20:21:47 UTC 2014
#27359: Color Picker Missing From WordPress 3.9
---------------------------+-----------------------------
Reporter: hardeepasrani | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Future Release
Component: TinyMCE | Version: 3.9
Severity: normal | Resolution:
Keywords: needs-patch | Focuses:
---------------------------+-----------------------------
Comment (by azaozz):
Replying to [comment:18 avryl]:
> I don't understand how this can be useful without being able to save
custom colours.
That's one of the reasons I think it is better to use the OS color picker
with `<input type="color">`. It would also integrate better with the
default TinyMCE picker.
On the other hand the plugin is quite good, you should definitely add it
to the plugin repository.
Few notes:
- It's a bit unclear what happens after the user has selected a color by
dragging the "handle". Would be good to have "OK" or "Apply" button.
- The tiny "color bar" under the icon in the button is intended to keep
the last selected color value and apply it on clicking the button. It
shouldn't change according to the current node's color.
- Thinking the "live preview" inside the editor while selecting a
color/dragging the handle is not needed. The text where the color is going
to be applied is usually selected at this tile. That makes the "live
preview" invisible. It also seems to make dragging of the handle to lag.
If you decide to keep it, it will need to be wrapped in
`editor.undoManager.transact()` so it doesn't add new undo level on every
color change.
- The CSS selectors need to be more specific so they don't override other
instances of Iris.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/27359#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list