[wp-trac] [WordPress Trac] #27708: Theme installer theme previewing fixes

WordPress Trac noreply at wordpress.org
Sun Apr 13 19:07:12 UTC 2014


#27708: Theme installer theme previewing fixes
--------------------------+-----------------------
 Reporter:  nacin         |       Owner:  matveb
     Type:  defect (bug)  |      Status:  reopened
 Priority:  high          |   Milestone:  3.9
Component:  Themes        |     Version:  trunk
 Severity:  minor         |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+-----------------------

Comment (by matveb):

 Haven't found an easy way to go around this with the way we've set it up —
 the same happens with a search route.

 To handle this properly I think the best is to:

 * Move listeners and non-sorting code out of the browse method and into
 render().
 * Handle a browse/sort route the same way as we’ll handle search and
 theme.
 * Set up a general event route for a vanilla url that triggers a Featured
 sort.

 browse was set up this way because we were bootstrapping data initially,
 but now it's a regular request, so it should be separate. I may be over
 thinking it but wasn't able to work around this.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/27708#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list