[wp-trac] [WordPress Trac] #27762: Remove whitespace between menu items

WordPress Trac noreply at wordpress.org
Sat Apr 12 07:53:39 UTC 2014


#27762: Remove whitespace between menu items
--------------------------------------+------------------------------
 Reporter:  obenland                  |       Owner:
     Type:  defect (bug)              |      Status:  new
 Priority:  normal                    |   Milestone:  Awaiting Review
Component:  Menus                     |     Version:  3.0
 Severity:  minor                     |  Resolution:
 Keywords:  good-first-bug has-patch  |     Focuses:
--------------------------------------+------------------------------

Comment (by Frank Klein):

 Removing the whitespace is just a really, really sucky solution.

 If you don’t want the space, then just use a negative margin or set the
 font-size of the parent element to 0. You can always reset that and it has
 the same effect without having to worry about trivial things like where
 you put your line breaks.

 We shouldn’t forget that people do all kinds of crazy with navigation
 menus from filtering to using Custom Walkers. So depending on having no
 line breaks is not a good idea.

 Also the commit in question is 4 years old, why change that now? Plenty of
 people don’t use a wp_nav_menu() fallback, so we cannot be sure that this
 is an “extreme edge case”.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/27762#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list