[wp-trac] [WordPress Trac] #27521: Theme Install Page is unusable via the keyboard

[WordPress Trac]

#27521: Theme Install Page is unusable via the keyboard
------------------------------+----------------------------------------
 Reporter:  jorbin            |       Owner:  nacin
     Type:  defect (bug)      |      Status:  closed
 Priority:  high              |   Milestone:  3.9
Component:  Themes            |     Version:  trunk
 Severity:  major             |  Resolution:  fixed
 Keywords:  has-patch commit  |     Focuses:  accessibility, javascript
------------------------------+----------------------------------------

Comment (by adamsilverstein):

 Oh, Backbone events - thats how to handle events! :)

 I noticed you added ._once around the nextTheme call on key-right, it was
 left off for previousTheme/key-left; Unless there is a specific reason for
 leaving off, we may want to add that, see [attachment:27521.20.diff]


 Replying to [comment:19 matveb]:
 > Use Backbone events to handle keyups on Preview. Fix bugs with the
 current model state persisting after you opened-navigate-close the
 Preview. Also hard prevents previous theme from going into a loop.
 >
 >
 > {{{$themeInstaller}}} could be {{{preview.$el}}} instead if we were to
 pass it to the function.
 >

--
Ticket URL: <https://core.trac.wordpress.org/ticket/27521#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform