[wp-trac] [WordPress Trac] #21785: Add header image uploads with cropping to the customizer

[WordPress Trac]

#21785: Add header image uploads with cropping to the customizer
----------------------------+-----------------------------------------
 Reporter:  nacin           |       Owner:
     Type:  task (blessed)  |      Status:  new
 Priority:  normal          |   Milestone:  3.9
Component:  Appearance      |     Version:  3.4
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:  javascript, administration
----------------------------+-----------------------------------------

Comment (by davidakennedy):

 I performed a quick retest, and things hold up well. A few points of
 feedback:

 * The tabindex attributes added here are not needed:
 https://github.com/ehg/wordpress-
 develop/commit/87c993635cff79e237732a61b76c06697d620251#commitcomment-5916062
 Is there a particular reason why they might be needed I'm missing? The
 source order here is very logical and everything can be tabbed to
 naturally so no need for the tabindex.
 * Everything still performs nicely with a screen reader.
 * The buttons that are images do not have the best visual indicator on
 focus. We've made some improvements with #27173. Can we add some kind of
 visual indicator here when those elements receive focus?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/21785#comment:75>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform