[wp-trac] [WordPress Trac] #16953: Allow symlinked plugins

[WordPress Trac]

#16953: Allow symlinked plugins
----------------------------------------------+-----------------------
 Reporter:  scribu                            |       Owner:  rmccue
     Type:  enhancement                       |      Status:  reopened
 Priority:  normal                            |   Milestone:  3.9
Component:  Plugins                           |     Version:
 Severity:  normal                            |  Resolution:
 Keywords:  has-patch dev-feedback 3.9-early  |     Focuses:
----------------------------------------------+-----------------------

Comment (by jdgrimes):

 Replying to [comment:115 nacin]:
 > It looks like [attachment:mu-symlinks.diff] would need to normalize
 paths on both sides of the conditional.

 The paths are normalized on 645-646 in the patch.

 > I'm open to suggestions as to what to do here. Do we resolve symlinks
 for single files, or only for full directories?
 As I said above, IMO, we should resolve symlinks for single files for
 consistency. Though it may not be useful for `plugins_url()`, it would
 standardize the behavior of `plugin_basename()` for all symlinks.

 > I'm surprised it took us this long to notice. What's the best path
 forward? We'll have no choice but to revert the whole thing for 3.9 unless
 there is a plan of action on how to proceed.

 I'd really hate to see this get reverted now. I think the reason we took
 so long to notice was that it really isn't that important in terms of
 `plugins_url()`. We could skip them for now and add them in later if
 needed. But I don't see any reason not to go ahead and resolve them. In
 the rare situation where a single-file plugin might need to use
 `plguins_url()` relative to itself it can't.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/16953#comment:116>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform