[wp-trac] [WordPress Trac] #27656: PHP Strict Standards: Only variables should be passed by reference in wp-includes/class-oembed.php on line 139

[WordPress Trac]

#27656: PHP Strict Standards: Only variables should be passed by reference in wp-
includes/class-oembed.php on line 139
--------------------------+-----------------------
 Reporter:  markjaquith   |       Owner:  dd32
     Type:  defect (bug)  |      Status:  assigned
 Priority:  low           |   Milestone:  3.9
Component:  Embeds        |     Version:
 Severity:  minor         |  Resolution:
 Keywords:                |     Focuses:
--------------------------+-----------------------
Changes (by nacin):

 * owner:   => dd32
 * status:  new => assigned


Comment:

 Let's just make a decision one way or another here. I'm fine with just
 papering over the notice now if we think removing the byref late in a
 release cycle might have unintended or unpredictable side effects.

 These functions never actually modify $response, but $response can be more
 than just an object. It's WP_Error on failure but otherwise it's a big
 array on success. (Replacing this with an object with ArrayAccess could be
 interesting, at some point.)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/27656#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform