[wp-trac] [WordPress Trac] #21785: Add header image uploads with cropping to the customizer
WordPress Trac
noreply at wordpress.org
Wed Apr 2 12:28:46 UTC 2014
#21785: Add header image uploads with cropping to the customizer
----------------------------+-----------------------------------------
Reporter: nacin | Owner:
Type: task (blessed) | Status: new
Priority: normal | Milestone: 3.9
Component: Appearance | Version: 3.4
Severity: normal | Resolution:
Keywords: has-patch | Focuses: javascript, administration
----------------------------+-----------------------------------------
Comment (by ehg):
Replying to [comment:54 nacin]:
> * [attachment:21785-suggested-dimensions.diff] — I agree, mhg, that
this is not ideal. Sorry for sending you on that goose chase. One of the
reasons the original suggested dimensions didn't get committed is that it
had this pretty weird hack with regards to the media manager title. I'm
fine with the design, but I'd want to inject that view in another way.
Yep, the hack was necessary because the title isn't easily as easily
editable as the rest of the MM views, such as the toolbar and content. We
could turn the titlebar itself into a region, to give us cleaner code and
more flexibility in the future - but this would involve significant
changes, which probably aren't appropriate at this time in the release
cycle.
Should we just rely on the suggested dimensions being in the Header
control for now, and revisit this for a later release?
--
Ticket URL: <https://core.trac.wordpress.org/ticket/21785#comment:61>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list