[wp-trac] [WordPress Trac] #18200: Language Packs

[WordPress Trac]

#18200: Language Packs
---------------------------------+-----------------------
 Reporter:  nacin                |       Owner:  nacin
     Type:  task (blessed)       |      Status:  accepted
 Priority:  normal               |   Milestone:  3.7
Component:  Upgrade/Install      |     Version:
 Severity:  normal               |  Resolution:
 Keywords:  3.7-early has-patch  |
---------------------------------+-----------------------

Comment (by nacin):

 Replying to [comment:71 dd32]:
 > > In 23912: WP_Upgrader: Add upgrader_process_complete hooks and add a
 abort_if_destination_exists flag (default is true). props dd32. see
 #18200.
 >
 > I just noticed that `upgrader_process_complete` passes the 3rd arguement
 as $plugin or $theme (ie. the item to update), where as core passes
 $result, the result of the upgrade process.
 > As a result, only Core upgrades are able to detect if the upgrade
 failed.
 >
 > I noticed this because Upon a core upgrade failing, Language packs
 proceed to try to update themselves, thus, a method to detect core,
 plugin, and theme update failures via the filter would be good.

 I think we should shift $plugin and $theme to argument 4, and make $result
 always the third argument. Or, we could set the $package to be the third
 argument for core updates, and make $result always the fourth argument.
 Either way.

 For bulk plugins/themes, is a single $result all we need? Or is it an
 array of results? I think we should still try to update languages even
 when something goes wrong in bulk.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/18200#comment:73>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software