[wp-trac] [WordPress Trac] #25389: Twenty Fourteen: Browser height is not filled for short content
WordPress Trac
noreply at wordpress.org
Sun Sep 29 20:12:37 UTC 2013
#25389: Twenty Fourteen: Browser height is not filled for short content
-------------------------------------+--------------------
Reporter: wycks | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 3.8
Component: Bundled Theme | Version: trunk
Severity: normal | Resolution:
Keywords: 2nd-opinion ui-feedback |
-------------------------------------+--------------------
Comment (by taupecat):
Replying to [comment:8 lancewillett]:
> We could only apply the rule when no footer widgets exist, based on
{{{body_class}}} value.
So right now, there is no change in the {{{body_class}}} value when there
are footer widgets, based on my observations at least. So a patch for
this would need to:
* Set the {{{body_class}}} with a footer widget indicator
* Change the CSS to require that {{{body_class}}} be present in order to
apply the 100vh
Additionally, we should probably change the "height: 100vh" to be "min-
height: 100vh", as that's more precisely what we're trying to accomplish.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/25389#comment:10>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list