[wp-trac] [WordPress Trac] #22840: Uploading an existing plugin saves the zip in media library

[WordPress Trac]

#22840: Uploading an existing plugin saves the zip in media library
-----------------------------+--------------------
 Reporter:  Ipstenu          |       Owner:
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  3.7
Component:  Upgrade/Install  |     Version:  3.4.2
 Severity:  normal           |  Resolution:
 Keywords:                   |
-----------------------------+--------------------

Comment (by dd32):

 > But, it seems like we might not always have an ID, based on the elseif
 in the current cleanup() method?

 The File_Uploader handler DOES remove the file (It queues a single cronjob
 for +2hours - that can be reduced to 30m) when the file is uploaded
 directly via it.
 {{{
 wp-includes/default-filters.php
 260:add_action( 'upgrader_scheduled_cleanup', 'wp_delete_attachment'
 );
 }}}

 I can't remember exactly, but I suspect there's a back-compat case there,
 where the class was used for installing from a local package rather than
 an uploaded file.

 So, Aside from the deletion time being 2hours (which is overly long), I
 don't see anything that *needs* to change here for 3.7

--
Ticket URL: <http://core.trac.wordpress.org/ticket/22840#comment:9>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software