[wp-trac] [WordPress Trac] #23807: PHP Strict Mode : Bulk_Plugin_Upgrader_Skin::before() warning

[WordPress Trac]

#23807: PHP Strict Mode : Bulk_Plugin_Upgrader_Skin::before() warning
------------------------------+---------------------
 Reporter:  charlestonsw      |       Owner:  ryan
     Type:  defect (bug)      |      Status:  closed
 Priority:  normal            |   Milestone:  3.6
Component:  Warnings/Notices  |     Version:  3.5.1
 Severity:  minor             |  Resolution:  fixed
 Keywords:                    |
------------------------------+---------------------

Comment (by SergeyBiryukov):

 Replying to [comment:3 soulseekah]:
 > Does `Bulk_Upgrader_Skin` also have to match the declarations of the
 above methods in `WP_Upgrader_Skin`?

 Well, it doesn't produce the strict standards warning, so I guess we're
 good. As far as I can see, adding new optional arguments in overridden
 methods is fine, removing or changing existing arguments is not.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/23807#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software