[wp-trac] [WordPress Trac] #25367: Document WP_Query and related class arguments
WordPress Trac
noreply at wordpress.org
Tue Sep 24 18:13:59 UTC 2013
#25367: Document WP_Query and related class arguments
------------------------------------+---------------------------
Reporter: DrewAPicture | Owner: DrewAPicture
Type: task (blessed) | Status: assigned
Priority: normal | Milestone: 3.7
Component: Inline Docs | Version:
Severity: normal | Resolution:
Keywords: has-patch dev-feedback |
------------------------------------+---------------------------
Comment (by Viper007Bond):
Awesome. Nice work!
Here's my feedback on the `WP_Date_Query` stuff:
* If we're going to document the class via it's constructor, then it
probably makes sense to remove a large portion of the PHPdoc that's at the
top of the class. No need to duplicate.
* Probably worth mentioning that the list of acceptable columns is
filterable.
* For `before` and `after`, if you're passing an array, then the month and
day fields are optional (you don't have to supply all three). For `before`
it defaults to January and/or the first day of the month and for `after`,
it defaults to December and/or the last day of the month. This way you can
just say "before 2013" or "before June 2013".
* I think we can improve the wording for `inclusive`, but I'm not sure
exactly how.
* The "accepts" for `$default_column` is missing.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/25367#comment:3>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list