[wp-trac] [WordPress Trac] #25382: Hook Docs: wp-includes/l10n.php

WordPress Trac noreply at wordpress.org
Sun Sep 22 15:11:43 UTC 2013

#25382: Hook Docs: wp-includes/l10n.php
 Reporter:  Nao          |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  3.7
Component:  Inline Docs  |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |

Comment (by DrewAPicture):

 Hi Nao,

 [attachment:25382.diff] is really close to ready, just a few tweaks:
 * Looks like you missed a `@param` description for for the `plugin_locale`
 and `theme_locale` filters
 * Change "Optional. Unique identifier for retrieving translated strings."
 to "Optional. Text domain. Unique identifier for retrieving translated
 strings." since we're preparing to change it through the rest of the file
 * Closing `*/` on each block needs to be indented once space
 * Would you mind spacing out the docblocks everywhere the way you did for
 the `gettext` and `gettext_with_context` filters? It really improves

 I think with those tweaks above this will be ready to go in. Thanks for
 the patch!

Ticket URL: <http://core.trac.wordpress.org/ticket/25382#comment:2>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software

More information about the wp-trac mailing list