[wp-trac] [WordPress Trac] #25357: Hook Docs: wp-admin/includes/class-wp-plugin-install-list-table.php

[WordPress Trac]

#25357: Hook Docs: wp-admin/includes/class-wp-plugin-install-list-table.php
--------------------------+------------------
 Reporter:  naomicbush    |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  3.7
Component:  Inline Docs   |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |
--------------------------+------------------
Changes (by DrewAPicture):

 * keywords:  reporter-feedback has-patch => needs-patch
 * milestone:  Awaiting Review => 3.7


Comment:

 Hi Noami, thanks for the patch :)

 Some notes on [attachment:25357.diff]:
 * `install_plugins_tabs` filter: "Filter the tabs that are shown on the
 page." needs to be more specific. It's best to document hooks as if they
 are independent of each other. So maybe, "Filter the tabs that are show on
 the Plugin Install screen." For the @param description, maybe "An array of
 tabs used on the Plugin Install screen." or something
 * `install_plugins_nonmenu_tabs` filter: "Filter the $nonmenu_tabs." isn't
 very helpful information. Perhaps something like "Filter tabs not
 associated with a menu item." Same for the @param description. I know it's
 copied from the function, but it's kind of vague and unhelpful. Try to be
 clear and direct.
 * `install_plugins_table_api_args_$tabs` filter: "Plugin API" should be
 "Plugin Installer API", "the $tab." should be "each tab."
 * `install_plugins_table_header` action: Again, think of all hooks as
 independent of each other, so you need to provide context in the
 description. "Fires before table header" should be "Fires before Plugin
 Install table header"
 * `plugin_install_action_links` filter: "the plugin." should be
 generalized to "a plugin."

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25357#comment:3>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software