[wp-trac] [WordPress Trac] #22917: Allow Live Updating of User & Site number in Multisite network dashboard 'Right Now' meta box
WordPress Trac
noreply at wordpress.org
Fri Sep 20 04:32:49 UTC 2013
#22917: Allow Live Updating of User & Site number in Multisite network dashboard
'Right Now' meta box
-------------------------+------------------
Reporter: vmaia | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 3.7
Component: Multisite | Version: 3.5
Severity: normal | Resolution:
Keywords: has-patch |
-------------------------+------------------
Comment (by adamsilverstein):
Replying to [comment:24 jeremyfelt]:
> [attachment:22917.5.diff] is a refresh against trunk. The patch combines
tests and src into one and cleans things up a bit.
>
> Replying to [comment:23 nacin]:
> > One option could be to have a maybe_update_*-style function that then
runs the filter, to consolidate the logic.
> Skipped this for now. Open to the idea, as the opposites generated
through the `! wp_is_large_network()` stuff are a bit strange feeling.
>
> > It might also make sense for it to be the same filter —
enable_live_network_counts, with context passed for 'users' or 'sites'.
> Went with this in the updated approach. Should be nicer to add this
filter as a dev and react on context. Likely the return will be the same
for both anyway.
>
> Also updated the tests a bit. By moving to one filter name, it
highlighted the necessity to use `remove_filter()` for both tests to avoid
conflicts.
>
> The new `enable_live_network_counts` filter has docs in this patch as
well.
This looks good, thanks! I like your improvement by combining the filters.
Cheers :)
--
Ticket URL: <http://core.trac.wordpress.org/ticket/22917#comment:25>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list