[wp-trac] [WordPress Trac] #25350: Make URL parameter for activation key parameter filterable

WordPress Trac noreply at wordpress.org
Thu Sep 19 18:15:28 UTC 2013

#25350: Make URL parameter for activation key parameter filterable
 Reporter:  boonebgorges  |       Owner:
     Type:  enhancement   |      Status:  new
 Priority:  normal        |   Milestone:  Future Release
Component:  Multisite     |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |

Comment (by boonebgorges):

 Replying to [comment:5 SergeyBiryukov]:
 > A new function is probably not necessary, we could just apply the filter
 in these three instances, like we did for `register` filter in [23558].

 Yup, whatever the WP convention is for such things. The one small argument
 in favor of a standalone function is that some plugins may be filtering
 the notification messages, which will require retrieving the filtered key.
 See eg http://buddypress.trac.wordpress.org/browser/tags/1.8.1/bp-core/bp-
 core-filters.php#L275, line 277. This is marginally cleaner to do if
 there's a function, rather than running `apply_filters()` ourselves.

 > Also we look at both GET and POST for that key (not sure why not in
 REQUEST), seems the renamed key will have to be supported for POST too.

 That makes sense. See 25350.04.patch.

 > Not even sure we need a specialized filter for the key.

 I think it's valuable to have a filter on it, because you never know what
 kind of dumb rules some specific mail program will impose, and the filter
 allows for flexibility. Whether it needs to be *specialized*, I guess I
 don't know. The same issue arises with password reset URLs - I can write a
 separate patch for that, or roll it into this one, if we're agreed on the
 approach - and I suppose it'd be fine to use the same filter for each.

Ticket URL: <http://core.trac.wordpress.org/ticket/25350#comment:7>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software

More information about the wp-trac mailing list