[wp-trac] [WordPress Trac] #25353: Hook Docs: wp-admin/admin-header.php

Thu Sep 19 05:40:43 UTC 2013

#25353: Hook Docs: wp-admin/admin-header.php
-------------------------+------------------
 Reporter:  ericlewis    |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  3.7
Component:  Inline Docs  |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  needs-patch  |
-------------------------+------------------
Changes (by DrewAPicture):

 * keywords:  has-patch => needs-patch
 * milestone:  Awaiting Review => 3.7


Comment:

 Looking at [attachment:25353.diff]:
 * Space out the specific action lines per coding standards
 * L#199-219, you'll need to convert the if/elseif/else to use curly braces
 since each conditional is now multi-line with the addition of the
 docblocks
 * There needs to be a long description in the block for `admin_body_class`
 mentioning that this differs from the other `*_class` filter hooks in that
 certain admin body classes cannot be filtered out, namely `wp-admin wp-
 core-ui no-js`
 * Should be "Fires in <head> for a specific admin page." L#109
 * Should be "Fires in <head> for all admin pages." L#116
 * Generally: "this specific admin page." should be more like "a specific
 admin page based on $hook_suffix."

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25353#comment:2>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software