[wp-trac] [WordPress Trac] #25351: Updating the 'jquery-masonry' to a latest version

WordPress Trac noreply at wordpress.org
Wed Sep 18 21:00:07 UTC 2013


#25351: Updating the 'jquery-masonry' to a latest version
--------------------------------+------------------------------
 Reporter:  rohitink            |       Owner:
     Type:  enhancement         |      Status:  new
 Priority:  normal              |   Milestone:  Awaiting Review
Component:  External Libraries  |     Version:  3.6.1
 Severity:  normal              |  Resolution:
 Keywords:  has-patch           |
--------------------------------+------------------------------

Comment (by nacin):

 Replying to [comment:1 helen]:
 > Seems that v3 introduced breaking (not backwards compatible) changes?

 Correct. Grumble.

 WordPress should introduce a `wp.masonry` wrapper (or something to that
 effect) that can attempt to offer backwards compatibility for future
 breaking changes. We might even be able to hijack the Masonry object and
 make it an instance of our object. It should be fairly easy to ensure back
 compat, all that changed were some options:
 http://masonry.desandro.com/appendix.html#upgrading-from-v2.

 Another alternative is forking it and making our own backwards compatible
 build. I haven't asked the maintainer yet if he would be willing to help
 support such a build, but I doubt it.

 The final alternative is just upgrading it and ignoring the back compat
 issues. We will have to update core for isRTL => isOriginLeft, but I don't
 think that would affect any others. I would suggest, as I did above, we
 build our own wrapper for future plugin and theme use. We could also ask
 the maintainer if he plans for version 4 to contain so many backwards
 incompatible changes, and whether there is anything we could do to
 prepare.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25351#comment:2>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list