[wp-trac] [WordPress Trac] #25325: Twenty Fourteen: Allow pages to have featured images

WordPress Trac noreply at wordpress.org
Wed Sep 18 14:42:32 UTC 2013

#25325: Twenty Fourteen: Allow pages to have featured images
 Reporter:  iamtakashi               |       Owner:
     Type:  enhancement              |      Status:  new
 Priority:  normal                   |   Milestone:  3.8
Component:  Bundled Theme            |     Version:  trunk
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |

Comment (by iamtakashi):

 Replying to [comment:3 Frank Klein]:

 > * Does the featured image need a link wrapped around it? On a page, it
 only links to itself, which seems redundant. The same applies to single
 posts by the way.

 We can definitely remove the link wrapper for pages and use a `div`
 instead but maybe it's a good idea to remove the link wrapper for both
 pages and posts altogether? I've just realised featured images are not
 linked in both Twenty Twelve and Twenty Thirteen.

 Many magazine sites in wild usually link a lead image to its single view
 though. Of course, we can alter the markup with a conditional tag but I'm
 not sure if it's worth to do for the sake of simplicity.

 > * If you set a featured image and use the full-width template, it looks
 kind of broken (image to short, header not overlapping,.... This is
 related to/dependent on #25031. I think we might need to check if there is
 a featured image set on the full width page and then apply the
 corresponding style (via `.has-featured-image` or something similar).

 I'll revise the full-width treatment when #25332 progresses.

 Another thing I'd like to hear opinions is that the theme should display
 the placeholder if there is no featured image on a page. I'm slightly
 leaning towards to not to display at the moment actually. What do you guys

Ticket URL: <http://core.trac.wordpress.org/ticket/25325#comment:6>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software

More information about the wp-trac mailing list