[wp-trac] [WordPress Trac] #25325: Twenty Fourteen: Allow pages to have featured images
WordPress Trac
noreply at wordpress.org
Wed Sep 18 08:49:43 UTC 2013
#25325: Twenty Fourteen: Allow pages to have featured images
-------------------------------------+--------------------
Reporter: iamtakashi | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 3.8
Component: Bundled Theme | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch needs-testing |
-------------------------------------+--------------------
Comment (by Frank Klein):
Here is my feedback concerning the patch:
* The patch doesn't apply properly, since it's made against src/wp-
content.
* Does the featured image need a link wrapped around it? On a page, it
only links to itself, which seems redundant. The same applies to single
posts by the way.
* If you set a featured image and use the full-width template, it looks
kind of broken (image to short, header not overlapping,.... This is
related to/dependent on #25031. I think we might need to check if there is
a featured image set on the full width page and then apply the
corresponding style (via `.has-featured-image` or something similar).
--
Ticket URL: <http://core.trac.wordpress.org/ticket/25325#comment:3>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list