[wp-trac] [WordPress Trac] #25333: Can't remove theme support for certain custom header arguments

[WordPress Trac]

#25333: Can't remove theme support for certain custom header arguments
-------------------------------------+------------------------------
 Reporter:  kovshenin                |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  Themes                   |     Version:  3.4
 Severity:  normal                   |  Resolution:
 Keywords:  needs-patch 2nd-opinion  |
-------------------------------------+------------------------------
Changes (by nofearinc):

 * keywords:  needs-patch => needs-patch 2nd-opinion


Comment:

 Confirmed, I can reproduce and the problem here is in the defines (they're
 indeed triggered in `add_theme_support` for the first call and just reused
 for all other calls).

 I was thinking of using a global array instead of the defines in
 `add_theme_support` and then converting to defines afterwards, but most
 themes (including default ones) use defines on `after_setup_theme`.

 Maybe nacin has a wiser idea, I see it as wontfix with hooking earlier in
 the life cycle if that needs to be refined.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25333#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software