[wp-trac] [WordPress Trac] #25208: Missing ntlm_sasl_client.php - it's a mistery

[WordPress Trac]

#25208: Missing ntlm_sasl_client.php - it's a mistery
--------------------------------+----------------------
 Reporter:  Claudiu Ceia        |       Owner:
     Type:  defect (bug)        |      Status:  closed
 Priority:  normal              |   Milestone:
Component:  External Libraries  |     Version:  3.6
 Severity:  minor               |  Resolution:  wontfix
 Keywords:                      |
--------------------------------+----------------------

Comment (by bpetty):

 Replying to [comment:9 Claudiu Ceia]:
 > > There are two modes for how HHVM can treat pre compiled code:
 > >
 > > 1) Always use the pre-compiled package and never check the source
 (much faster)
 > > 2) Fallback to an actual file if it can't find it in the pre-compiled
 package. (fast, but not as fast as it can be)
 >
 > Completion: for #2 it works fine with HHVM, it will just be a runtime
 exception if that code path is reached, just like it normally does. My
 question is, why would that code path be there if it's not supported and
 we want to kill it? I don't see the reason.

 Here's the thing that bugs me... if this is a problem, then it's also
 certainly a problem for the other files we don't include as well. This
 includes extras/htmlfilter.php, since PHPMailer also conditionally
 includes that when the appropriate method is called in class-phpmailer.php
 too, and we don't bundle that either. Just adding ntlm_sasl_client.php
 wouldn't be enough to fix your problem with HHVM, we'd also need to
 include the rest of the files as well.

 If you're able to get around that with HHVM, there's certainly a way to
 get around it with ntlm_sasl_client.php too.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25208#comment:10>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software