[wp-trac] [WordPress Trac] #25085: Twenty Fourteen: Fix Genericons Loading

[WordPress Trac]

#25085: Twenty Fourteen: Fix Genericons Loading
------------------------------+---------------------------
 Reporter:  celloexpressions  |       Owner:  lancewillett
     Type:  defect (bug)      |      Status:  reopened
 Priority:  normal            |   Milestone:  3.8
Component:  Bundled Theme     |     Version:  trunk
 Severity:  normal            |  Resolution:
 Keywords:  has-patch         |
------------------------------+---------------------------

Comment (by obenland):

 > The purpose of this ticket is specifically NOT to do that. If we use a
 different handle, then we're only trying to step around the problem
 instead of actually fixing it.

 I agree, we shouldn't register/enqueue our own version of genericons.

 [[BR]]

 > The only big problem with the raw Genericons css is that it adds styles
 to .genericon instead of .genericon:before, which is why Twenty Fourteen
 can get pretty nasty with that. @obenland, did Joen have a reason for
 doing that, or was it accidental and forgotten to be fixed (see comment
 1)?

 I submitted a patch upstream and I thought he wanted to use that in 3.0. I
 think he had back compat concerns, not sure.

 [[BR]]

 > If that's staying, we should adjust our uses of those classes in Twenty
 Fourteen so that we can use the bundled css.

 Yes, I think that'd be the most painless way to deal with that.

 [[BR]]

 > And it looks like the syntax that Twenty Fourteen is using [...] doesn't
 seem to have been in any of the .zip download releases ever available
 through genericons.com. So if you want to use that in the genericons
 twentyfourteen style, I mean, go ahead, but be aware that you're
 intentionally forking genericons.css.

 > It looks like the non-standard selector traced back to Obenland's patch
 on #24595.

 The syntax was part of the patch I submitted upstream, Genericons was
 supposed to pick that up. Since then it turned out that using class
 attribute selectors in WordPress are not a good idea, so this will be
 (would have been) reverted eventually.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25085#comment:11>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software