[wp-trac] [WordPress Trac] #25208: Missing ntlm_sasl_client.php - it's a mistery

[WordPress Trac]

#25208: Missing ntlm_sasl_client.php - it's a mistery
--------------------------------+----------------------
 Reporter:  Claudiu Ceia        |       Owner:
     Type:  defect (bug)        |      Status:  closed
 Priority:  normal              |   Milestone:
Component:  External Libraries  |     Version:  3.6
 Severity:  minor               |  Resolution:  wontfix
 Keywords:                      |
--------------------------------+----------------------

Comment (by Claudiu Ceia):

 > Well, one of the big issues with adding it now is that we've never had
 it in there before, so we also never had to deal with the issue of
 supporting something that was was supported in the past - but shouldn't be
 because no-one should be using it at this point

 I don't see the need to support that switch branch then... is there
 something I'm missing?

 > What would be a better solution to your HHVM problem would be to submit
 a patch to PHPMailer upstream that knows to conditionally check for that
 file since it is actually supposed to be an optional "extra" feature
 anyway.

 That won't fix the issue with HHVM I'm afraid (actually, it conditionally
 requires that file as well). The problem is that during pre-compilation
 HHVM can't know if that condition will be reached or not - it only knows
 at runtime. The only way it can compile the source correctly is by making
 sure the file exists.

 There are two modes for how HHVM can treat pre compiled code:

 1) Always use the pre-compiled package and never check the source (much
 faster)
 2) Fallback to an actual file if it can't find it in the pre-compiled
 package. (fast, but not as fast as it can be)


 I guess my question is, is the expectation that WordPress users would be
 adding the files they need for SMTP to work? Shouldn't NTLM be killed
 completely?

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25208#comment:8>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software