[wp-trac] [WordPress Trac] #25208: Missing ntlm_sasl_client.php - it's a mistery

[WordPress Trac]

#25208: Missing ntlm_sasl_client.php - it's a mistery
--------------------------------+----------------------
 Reporter:  Claudiu Ceia        |       Owner:
     Type:  defect (bug)        |      Status:  closed
 Priority:  normal              |   Milestone:
Component:  External Libraries  |     Version:  3.6
 Severity:  minor               |  Resolution:  wontfix
 Keywords:                      |
--------------------------------+----------------------

Comment (by Claudiu Ceia):

 > The SMTP class works just fine provided SMTP::Authenticate() is called
 with an $authtype of LOGIN (default) or PLAIN.


 Right. However, I would classify it as a bug if a system allows me to do
 something and then breaks. I think there are a couple of things you guys
 should consider:

 1) People that call `SMTP::Authenticate()` by passing `NTLM` and didn't
 update to the latest version. Sure, it's not supported - the whole case
 block should be deleted and throw a meaningful exception would be the best
 option IMO.

 2) If the above doesn't match your roadmap / plans, What about just
 dropping in an empty file with that name and comment on what people need
 to do if they really want to use `NTLM`? At least the code won't throw a
 weird exception about not finding a file that is required but actually
 never meant to be there in the first place. I still think #1 is the best
 option though.

 Background: I'm trying to get Wordpress to run on
 [http://www.hhvm.com/blog/ HHVM]. It works fine, with a couple of lines
 changed. However, HHVM has an option to precompile the code. The pre-
 compilation step fails because it can't find that file. I can fork it and
 add the class, or customize the `SMTP` class - but I think the approach
 could be better in the `SMTP` class without me having to fork it.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25208#comment:6>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software