[wp-trac] [WordPress Trac] #25315: Theme Customizer preview wont load home URL

WordPress Trac noreply at wordpress.org
Fri Sep 13 18:01:04 UTC 2013


#25315: Theme Customizer preview wont load home URL
--------------------------+------------------------------
 Reporter:  stri8ed       |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Appearance    |     Version:  3.6.1
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |
--------------------------+------------------------------

Comment (by nacin):

 Looking at this, the JS does a `0 === test_url.indexOf( allowed_url )`
 check. The issue here being that `website.com.notmywebsite.com` would
 match that, unless we look for a trailing slash.

 I think we can make this work as long as we check `0 === indexOf` for a
 URL without a trailing slash, but then confirm that the next character is
 `/`, `#`, `?`, or that there is no last character (as in this example).

 This check isn't here for security, but it doesn't mean we should make it
 lax.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25315#comment:2>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list