[wp-trac] [WordPress Trac] #25308: wp_cache_set, wp_cache_add, set_transient should handle and notify on non-ints expirations
WordPress Trac
noreply at wordpress.org
Fri Sep 13 15:32:35 UTC 2013
#25308: wp_cache_set, wp_cache_add, set_transient should handle and notify on non-
ints expirations
------------------------------------+--------------------
Reporter: andreasnrb | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 3.7
Component: Cache | Version: 3.6.1
Severity: normal | Resolution:
Keywords: dev-feedback has-patch |
------------------------------------+--------------------
Comment (by andreasnrb):
Replying to [comment:2 nacin]:
> I think [attachment:25308.2.patch] is good here. If we wanted we could
add:
> {{{
> if ( false !== $expiration && ! is_int( $expiration ) )
> _doing_it_wrong( __FUNCTION__, '$expire should be an integer.' );
> }}}
>
> But I am not sure it is needed.
Could do so the notification is only generated if WP_DEBUG is true it
would at least limit the amount of notifications people get.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/25308#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list