[wp-trac] [WordPress Trac] #25259: Helper functions for mbstring.func_overload

[WordPress Trac]

#25259: Helper functions for mbstring.func_overload
--------------------------+-----------------------
 Reporter:  dd32          |       Owner:  dd32
     Type:  defect (bug)  |      Status:  reopened
 Priority:  normal        |   Milestone:  3.7
Component:  General       |     Version:
 Severity:  normal        |  Resolution:
 Keywords:                |
--------------------------+-----------------------
Changes (by nacin):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 I meant to comment here; it appears I didn't.

 Would it make sense to have a function specifically for strlen() that does
 the switch, the measurement, and the restoration? This seems to be the
 most common use case in core. mb_substr() is used more, and
 mb_strtolower() is also used a few times. It just might make things a bit
 more clear what is going on. I'm fine with the helpers, but it isn't
 entirely obvious what is going on in between the two points. Some of the
 gaps are 10 to 25 lines, with other function calls in between — and
 potentially filters? We should aim to keep this as atomic as possible.

 Reopening for review, especially given that this could have a side effect
 on other functions or plugins without thorough review.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25259#comment:8>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software