[wp-trac] [WordPress Trac] #22679: Ensure that inserted images linked to the attachment page get correct permalink format (was: Ensure that unattached images inserted from media library get pretty url directly)

[WordPress Trac]

#22679: Ensure that inserted images linked to the attachment page get correct
permalink format
-------------------------+------------------------------
 Reporter:  jond3r       |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  Awaiting Review
Component:  Media        |     Version:  3.5
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |
-------------------------+------------------------------

Comment (by jond3r):

 22679-2.diff is a refresh that adds checks that default permalinks are not
 used and that the post is not a draft or pending before calling
 {{{get_attachment_link()}}}.

 Even though the proposed change does not improve the final content of
 published posts, it adds transparency to the process of obtaining
 attachment links, instead of relying on {{{_fix_attachment_links()}}} to
 step in when the post is updated.

 Also as long as #25268 is not fixed, the proposed change ''will'' improve
 the final appearance of attachment links added to private and scheduled
 posts, see #25268 for details.

 Note that attachment links added to drafts still have to rely on
 {{{_fix_attachment_links()}}} to get their final format. This obviously
 lessens the value of the proposed change.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/22679#comment:5>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software