[wp-trac] [WordPress Trac] #18614: post_type_archive_title doesn't work when tax_query is added to wp_query

[WordPress Trac]

#18614: post_type_archive_title doesn't work when tax_query is added to wp_query
----------------------------------------+-----------------------------
 Reporter:  wonderboymusic              |       Owner:  wonderboymusic
     Type:  defect (bug)                |      Status:  reopened
 Priority:  normal                      |   Milestone:  3.7
Component:  Template                    |     Version:  3.2
 Severity:  normal                      |  Resolution:
 Keywords:  has-patch needs-unit-tests  |
----------------------------------------+-----------------------------
Changes (by nacin):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Sorry to be a pain, but I feel like the reset() in [25292] might not be
 the best place for this. Or at the very least, it needs docs.

 If you are passing an array to get_post_type_object(), you *may* be doing
 it wrong. For us to choose the first one (essentially picking favorites)
 could mean we are suppressing issues. While it might make sense in some
 places to choose the first one, it might not make sense in all places.
 This could potentially paper over a developer error. (Including, yes, an
 error where we have done this 8-10 times ourselves.)

 I was only musing for the template-loader.php change. Let's dig into that
 a bit more to make sure it won't break anything. Also, [25292] should have
 been two commits.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/18614#comment:35>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software