[wp-trac] [WordPress Trac] #25220: Twenty Fourteen: Let Users Customize the Green "Accent" Color
WordPress Trac
noreply at wordpress.org
Thu Sep 5 18:53:55 UTC 2013
#25220: Twenty Fourteen: Let Users Customize the Green "Accent" Color
------------------------------+--------------------
Reporter: celloexpressions | Owner:
Type: feature request | Status: new
Priority: normal | Milestone: 3.8
Component: Bundled Theme | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch |
------------------------------+--------------------
Comment (by obenland):
Patch looks good, only some minor formatting issues:
* [http://make.wordpress.org/core/handbook/coding-
standards/php/#indentation Use spaces to align things in a block of code].
* Comments should always have the first letter capitalized and end with a
period.
* Functions should have (at least) arguments and return value documents
with PHPDoc (no trailing empty line necessary)
As mentioned during chats, we should remove the priority argument and find
better names for `accent_1` and `accent_2`.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/25220#comment:3>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list