[wp-trac] [WordPress Trac] #13998: Inconsistency in arguments when wp_nav_menu falls back to wp_page_menu

WordPress Trac noreply at wordpress.org
Wed Sep 4 11:35:28 UTC 2013


#13998: Inconsistency in arguments when wp_nav_menu falls back to wp_page_menu
-------------------------+-----------------------------
 Reporter:  Utkarsh      |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  Future Release
Component:  Menus        |     Version:  3.0
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |
-------------------------+-----------------------------
Changes (by Frank Klein):

 * cc: contact@… (added)
 * keywords:  needs-patch => has-patch


Comment:

 The updated patch with contains the following elements:
 * Add a `ul_class` argument to `wp_page_menu`.
 * Remap the `menu_class` from `wp_nav_menu` to `ul_class` before passing
 it to `wp_page_menu`.
 * Updated inline documentation.
 * Some whitespace fixes and other code standards adaptations.

 I think that there are other possible enhancements that can be added to
 the `wp_page_menu` function, specifically some of the arguments used by
 `wp_nav_menu` such as:

 * container
 * container_id
 * menu_id
 * before
 * after
 * items_wrap
 * depth

 As far as I see, it should be possible to implement these arguments in
 `wp_page_menu` as well without breaking existing themes. I think
 especially the `depth` argument might be a worthwhile addition, what do
 you think?

--
Ticket URL: <http://core.trac.wordpress.org/ticket/13998#comment:7>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list