[wp-trac] [WordPress Trac] #25771: Only check for is_writable() pre-update for the files to which we need to write
WordPress Trac
noreply at wordpress.org
Wed Oct 30 13:53:13 UTC 2013
#25771: Only check for is_writable() pre-update for the files to which we need to
write
-----------------------------+-----------------------
Reporter: nacin | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 3.7.2
Component: Upgrade/Install | Version:
Severity: normal | Keywords: has-patch
-----------------------------+-----------------------
Before an update, we check the entire list of files in WordPress, based on
a list of all checksums, to see if any need changing. If so, we then check
to see if the file is writable. The files_not_writable error code occurs
when a file we've determined we need to copy over is not writable, even
after chmod 0644.
dd32 and I noticed an error condition where an incomplete update to 3.7
resulted in some about page image files not being created in wp-
admin/images. For 3.7.1, files_not_writable was thrown because the
checksums did not match for those files. But since a partial build was
being used, there was no file to actually copy over in the working
directory, even if we could write to it.
We should only perform is_writable() pre-update checks for files to which
we need to write. If something goes wonky during a previous update, we can
try to make sure that doesn't affect a partial build update to 3.7.1.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/25771>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list