[wp-trac] [WordPress Trac] #23756: make_clickable should not convert the URLs in pre, code tags

WordPress Trac noreply at wordpress.org
Tue Oct 29 17:40:43 UTC 2013


#23756: make_clickable should not convert the URLs in pre,code tags
----------------------------------------------------+--------------------
 Reporter:  alex-ye                                 |       Owner:
     Type:  defect (bug)                            |      Status:  new
 Priority:  normal                                  |   Milestone:  3.8
Component:  Formatting                              |     Version:  3.5.1
 Severity:  normal                                  |  Resolution:
 Keywords:  has-patch needs-testing has-unit-tests  |
----------------------------------------------------+--------------------

Comment (by kpdesign):

 I've been watching this ticket, as this is an issue that affects the
 handbooks. The handbooks use the
 [http://wordpress.org/plugins/syntaxhighlighter/ SyntaxHighlighter
 Evolved] plugin, and all of the code samples containing URLs are broken
 (they display full markup for a URL instead of just the URL). See
 [http://make.wordpress.org/core/handbook/automated-testing/#installation
 Automated Testing > Installation] for an example.

 I applied [attachment:23756.5.diff] to my local install (latest trunk),
 tested, and got the expected results listed in the unit test.

 This patch also fixed my local test code samples using the shortcodes in
 the plugin (no markup added to URLs).

 {{{
 Code:

 [sourcecode lang="bash"]
 $ URL https://core.trac.wordpress.org/attachment/ticket/00000/00000.patch
 $ Email name at domain.tld
 $ FTP ftp://user:password@domain.tld/path
 [/sourcecode]

 Generated markup:

 <pre class="brush: bash; title: ; notranslate" title="">
 $ URL https://core.trac.wordpress.org/attachment/ticket/00000/00000.patch
 $ Email name at domain.tld
 $ FTP ftp://user:password@domain.tld/path
 </pre>
 }}}

--
Ticket URL: <http://core.trac.wordpress.org/ticket/23756#comment:19>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list