[wp-trac] [WordPress Trac] #25721: Consolidate a couple of filters to the WP_Image_Editor base class (was: Hooks Docs: wp-includes/class-wp-image-editor-gd.php and wp-includes/class-wp-image-editor-imagick.php)

WordPress Trac noreply at wordpress.org
Mon Oct 28 15:50:15 UTC 2013


#25721: Consolidate a couple of filters to the WP_Image_Editor base class
------------------------------------+------------------------
 Reporter:  markoheijnen            |       Owner:
     Type:  enhancement             |      Status:  reviewing
 Priority:  normal                  |   Milestone:  3.8
Component:  Media                   |     Version:  3.5
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |
------------------------------------+------------------------
Changes (by DrewAPicture):

 * owner:  DrewAPicture =>
 * type:  defect (bug) => enhancement
 * component:  Inline Docs => Media


Comment:

 Replying to [comment:7 markoheijnen]:
 > Maybe, I guess same ticket but separate patches would be better. You
 don't code something without docs and then create a separate ticket for
 the docs.

 Put another way, if the primary goal of the ticket is to do anything other
 than just document hooks, it's not a Hook Docs ticket. :)

 Here's some feedback on the docs in [attachment:25721.diff]:
 * `image_make_intermediate_size` - We need to pick which of these as the
 primary and mark the second one as a duplicate
 * Short descriptions and parameter descriptions should each end with a
 period.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25721#comment:8>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list