[wp-trac] [WordPress Trac] #25741: Broken WP_Filesystem methods

WordPress Trac noreply at wordpress.org
Mon Oct 28 03:18:03 UTC 2013


#25741: Broken WP_Filesystem methods
--------------------------+-----------------------------
 Reporter:  dd32          |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Filesystem    |    Version:
 Severity:  normal        |   Keywords:  has-patch
--------------------------+-----------------------------
 The following methods of WP_Filesystem do not work as intended, as they're
 called with absolute paths, and fail to find those absolute paths within
 the relative paths returned from the listing functions:
 * WP_Filesystem_FTPext
  * owner()
  * getchmod()
  * group()
 * WP_Filesystem_ftpsockets
  * owner()
  * getchmod()
  * group()

 It's worth noting that the following FTP methods are available but don't
 actually hit the filesystem, and are just there to match the
 `WP_Filesystem_Direct` methods:
 * is_readable()
 * is_writable()
 * atime()
 * touch()

 Attached is a patch I had locally from during 3.7 development, not
 thoughly tested, I believe WP_Filesystem_FTPext::owner() at least needs
 extra work.
 The patch also removes the above methods from the FTP classes and relies
 upon the `WP_Filesystem_Base` versions - as a result, the is_writable()
 and is_readable() methods changed to assume things are readable/writable.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25741>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list