[wp-trac] [WordPress Trac] #25735: paginate_links runs number_format_i18n for the entire range of pages

[WordPress Trac]

#25735: paginate_links runs number_format_i18n for the entire range of pages
--------------------------+------------------------------
 Reporter:  johnpbloch    |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  General       |     Version:  2.7
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+------------------------------

Comment (by johnpbloch):

 As a matter of curiosity, Nacin had wondered what performance looks like
 before and after applying the patch. Here are two cachegrind profiles, one
 from before and one from after:

 [http://cl.ly/1r3H3n0m2k0k Before]

 [http://cl.ly/102o3x1W0O2G After]

 This was on an installation with just north of 22,000 posts in the
 database. At that size, this defect added .1 second to the request and
 `number_format_i18n()` had a total self cost of 6.67% and a total
 inclusive cost of 11.69%. This is entirely in keeping with the data I saw
 when I first discovered the issue on a database with 110,000+ posts in the
 database.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25735#comment:3>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software