[wp-trac] [WordPress Trac] #19733: XML-RPC returns invalid dates if the date is zero

[WordPress Trac]

#19733: XML-RPC returns invalid dates if the date is zero
-----------------------------------------------+---------------------
 Reporter:  koke                               |       Owner:  westi
     Type:  defect (bug)                       |      Status:  closed
 Priority:  normal                             |   Milestone:  3.4
Component:  XML-RPC                            |     Version:  3.3
 Severity:  normal                             |  Resolution:  fixed
 Keywords:  has-patch mobile needs-unit-tests  |
-----------------------------------------------+---------------------

Comment (by ericmann):

 Replying to [comment:16 markoheijnen]:
 > I personally would go for 19733.tests.diff​. I think the reflection here
 is pretty easy to understand. It's a few lines of code and you did add a
 comment that you want to access a protected method.

 Easy to understand, but somewhat non-standard.  Hence the second patch as
 an alternative.

 > I personally would split each test case by having a standard and a null
 test case.

 While we could split them out, there's no real added benefit of doing
 that. Plus having the standard and null date in the same test method
 doesn't really have a drawback.  That said, if anyone else disagrees it
 would be trivial to split them.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/19733#comment:17>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software