[wp-trac] [WordPress Trac] #25655: Disable maintenance mode as early as possible

WordPress Trac noreply at wordpress.org
Tue Oct 22 10:48:26 UTC 2013


#25655: Disable maintenance mode as early as possible
------------------------------+------------------
 Reporter:  nacin             |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  3.7
Component:  Upgrade/Install   |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |
------------------------------+------------------

Comment (by dd32):

 Did some extra timing on the upgrade code.

 There's only 4 significant parts of the code
 - Downloading the package
 - Unziping the package
 - Updating the files
 - Performing the loopback HTTP request to upgrade the DB

 Everything outside of those steps is tiny and counted in a few ms here, a
 few ms there.

 [attachment:25655.3.diff] moves the disabling to the most logical place,
 after core and language files are moved, before extra themes and old files
 are dealt with, as nacin says above for most people it'll only be a few
 extra milliseconds in is_dir(), for others, it may be another second while
 it updates the language files.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25655#comment:7>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list