[wp-trac] [WordPress Trac] #25660: If an administrator triggers cron, a background update could temporarily lock them out

[WordPress Trac]

#25660: If an administrator triggers cron, a background update could temporarily
lock them out
-------------------------------------+------------------
 Reporter:  nacin                    |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  high                     |   Milestone:  3.7
Component:  Upgrade/Install          |     Version:
 Severity:  major                    |  Resolution:
 Keywords:  has-patch needs-testing  |
-------------------------------------+------------------

Comment (by nacin):

 I like azaozz's [attachment:25660.patch]. The only thing we should be
 concerned about is that we wanted to be certain in 3.6 that we weren't
 accidentally blocking someone from publishing just because their heartbeat
 or something is broken. 503 is specific enough, and meaningful enough,
 that we should be okay always treating a 503 as a connection issue. But,
 that code is also particular to the resource, not to the site. It's tough.
 I think I would like to see heartbeat work once before treating a 503 as
 an error. That way we at least know there aren't persistent 503 errors
 spewing from admin-ajax.php.

 Originally, heartbeat-connection-lost was to fire whenever heartbeat has
 been successful once, plus started failing one or more times. Only
 'timeout' would work regardless. But, the callback hooked into the
 heartbeat-connection-lost event specifically checks for 'timeout', and now
 also 503. In 3.8 it would be interesting to expand heartbeat-connection-
 lost to more than just timeout. We just have to be very careful that we
 are not flagging false positives.

 So, okay with [attachment:25660.patch]. I toyed with it a bit and came up
 with (untested) [attachment:25660.2.diff].

 ----

 dd32's patch is clever. Do we need it right now? I don't know. #25655
 might be enough alone.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25660#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software