[wp-trac] [WordPress Trac] #25652: Enforce some of our strictest update checks only for background updates

[WordPress Trac]

#25652: Enforce some of our strictest update checks only for background updates
-----------------------------+------------------
 Reporter:  nacin            |       Owner:
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  3.7
Component:  Upgrade/Install  |     Version:
 Severity:  normal           |  Resolution:
 Keywords:                   |
-----------------------------+------------------

Comment (by dd32):

 [attachment:25652.diff​] moves the `disk_free_space()` check in
 `unzip_file()` into a `DOING_CRON` check.
 We had previously talked about making it a warning for non-background
 updates, but I can't see an easy way to do that unfortunately.

 For the `files_not_writable` one, currently the major thing it'd catch is
 someone running a svn up as root and later trying to update as a regular
 user (not that the update would succeed in that case anyway).

 [attachment:25652.2.diff​] does as we've discussed previously to simply
 display it as an alert and not a failing case, this isn't designed for
 committing, more a talking point.
 I personally don't think we need to change this behaviour right now, half
 updating WordPress (even TinyMCE files) leads to user confusion and
 "broken sites" (ie. Visual editor not working correctly), just because the
 site doesn't fatal, doesn't mean it's not "broken" to a user.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25652#comment:1>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software