[wp-trac] [WordPress Trac] #25655: Disable maintenance mode as early as possible
WordPress Trac
noreply at wordpress.org
Mon Oct 21 19:20:42 UTC 2013
#25655: Disable maintenance mode as early as possible
-----------------------------+-----------------
Reporter: nacin | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 3.7
Component: Upgrade/Install | Version:
Severity: normal | Keywords:
-----------------------------+-----------------
To limit the amount of time we spend in maintenance mode, let's move it up
a few lines, to before the HTTP request to automatically trigger a DB
upgrade (which has a timeout of 60), and before the deletion of old files.
Normally, a DB upgrade would be triggered by anyone visiting wp-admin. We
do it ourselves, but I don't think we need to keep the site down in
maintenance mode during it. I'm not sure but I don't think it is easy for
a race condition to occur to trigger multiple upgrades at once. That said,
with possible major schema changes in the works in the future, we ''may''
want to keep the schema update behind maintance mode. But since this code
resides in the wp-admin/includes/update-core.php file that gets copied
over, that can be finagled with on a case-by-case basis.
In order to keep sites in maintenance mode for as little time as possible
(potentially only a few seconds), we should exit maintenance mode before
the DB upgrade for 3.7. Or, at worst, we should make sure old files don't
delay the maintenance mode.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/25655>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list