[wp-trac] [WordPress Trac] #25586: Hook Docs: wp-admin/my-sites.php

WordPress Trac noreply at wordpress.org
Thu Oct 17 12:43:22 UTC 2013


#25586: Hook Docs: wp-admin/my-sites.php
--------------------------+------------------------------
 Reporter:  megane9988    |       Owner:  kpdesign
     Type:  defect (bug)  |      Status:  reviewing
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Inline Docs   |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |
--------------------------+------------------------------
Changes (by kpdesign):

 * keywords:  has-patch => needs-patch
 * owner:   => kpdesign
 * status:  new => reviewing
 * type:  enhancement => defect (bug)


Comment:

 @megane9988: Thanks for the patch. :)

 Just a few things:

 `myblogs_allblogs_options`
 - "Fires after displays the selectbox for choose primary blog." should be
 "Fires after displaying the Choose Primary Site dropdown.".
 - Add a blank line between description and @since tag, per the
 [http://make.wordpress.org/core/handbook/inline-documentation-standards
 /php-documentation-standards/#4-hooks-actions-and-filters standard].
 - Remove extra whitespace after opening and closing tags for that block.

 `myblogs_options`
 - Description should be "Add settings to the Edit Site Settings screen".
 - Remove extra whitespace after * on blank lines.

 `myblogs_blog_actions`
 - Description should be "Filter the displayed links for each site."
 - Remove extra whitespace after * on blank lines.
 - Remove extra tabs at the end of the `apply_filters` line.

 Second instance of `myblogs_options` (line 80) should be
 `//duplicate_hook` instead of the full doc block.

 Could you make these changes, and submit a new patch please?

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25586#comment:1>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list