[wp-trac] [WordPress Trac] #25549: Twenty Fourteen: implement featured content "tag" mechanism
WordPress Trac
noreply at wordpress.org
Wed Oct 16 16:01:58 UTC 2013
#25549: Twenty Fourteen: implement featured content "tag" mechanism
---------------------------+--------------------
Reporter: lancewillett | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 3.8
Component: Bundled Theme | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch |
---------------------------+--------------------
Comment (by obenland):
Replying to [comment:8 lancewillett]:
> Patch looks good in testing. Only minor things I'd want to change in the
include file, mostly in code comments.
Right, a decision we still have to make is how far we want to deviate from
what is in Jetpack. Currently it's only text domains and a strict notice
fix (that will make its way upstream). Not bothering with the comments
would allow us to update it a lot easier in the future, along the lines of
Genericons.
[[BR]]
> Probably setting default to 6 for Twenty Fourteen for "quantity"
setting.
This touches my comment above, too. I specified this in the
`add_theme_support()` call to be compatible with existing data.
[[BR]]
> UX note: what do you think about changing the "Tag Name" entry to be a
dropdown of tags from the site? Maybe the most used at the top. If not a
dropdown, maybe an auto-complete so you don't have to remember or guess
the tag.
kovshenin's patch seems fairly trivial and also something we could pass on
upstream, I wouldn't mind doing that.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/25549#comment:11>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list