[wp-trac] [WordPress Trac] #25227: Change relative URL for wp-mediaelement in _wpmejsSettings to absolute

WordPress Trac noreply at wordpress.org
Tue Oct 15 15:20:12 UTC 2013


#25227: Change relative URL for wp-mediaelement in _wpmejsSettings to absolute
-------------------------------------------+------------------
 Reporter:  RussellYermal                  |       Owner:
     Type:  defect (bug)                   |      Status:  new
 Priority:  normal                         |   Milestone:  3.7
Component:  Media                          |     Version:  3.6
 Severity:  normal                         |  Resolution:
 Keywords:  2nd-opinion reporter-feedback  |
-------------------------------------------+------------------
Changes (by nacin):

 * keywords:  2nd-opinion => 2nd-opinion reporter-feedback


Comment:

 After looking at this for a while, I think there is a good chance that
 your filter on includes_url() is causing breakage, as well as causing the
 addition of 'http://'.

 Can you share your callback that you are using to serve your JS from an
 external CDN?

 We can't fix this in this manner — other things will break. This is also
 the only report we've received, and it ''seems'' to work on WordPress.com,
 which also offloads JavaScript.

 It seems that the includes_url filter in includes_url() should receive the
 requested $scheme. That said, it is not difficult to deduce the requested
 scheme from the incoming URL — simply look for `https:`, `http:`, or `/`
 at the start of the string.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25227#comment:5>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list