[wp-trac] [WordPress Trac] #25580: Twenty Fourteen: Custom Accent Color Variants are Published Too Soon
WordPress Trac
noreply at wordpress.org
Sat Oct 12 19:00:14 UTC 2013
#25580: Twenty Fourteen: Custom Accent Color Variants are Published Too Soon
------------------------------+-----------------------------
Reporter: celloexpressions | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Bundled Theme | Version:
Severity: normal | Keywords: needs-patch
------------------------------+-----------------------------
Go to the customizer. Select a new accent color. Wait a second for the
preview to update. Visit your site in new tab (or close the customizer
without saving and visit your site). The two generated variants of the
accent color that you previewed have been published, but the original
color is retained.
Basically, when we set the theme mods for the variants in the accent color
sanitization callback, they're being published live to the site and saved
immediately, rather than being saved only for the customizer and only
published when the customizer is saved. In addition to showing the world
the (variants of) colors you're previewing, this causes colors from two
different schemes to display (as the variants are of the new color, but
the original accent color is retained).
Kind of a nasty bug, but only if the other colors you're trying out are
much different or clash horribly. The variant colors only show up in
hover-states (I think), so it's kind of hard to notice immediately.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/25580>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list