[wp-trac] [WordPress Trac] #25572: 3.7-beta2-25760 - warning message on update-core.php

[WordPress Trac]

#25572: 3.7-beta2-25760 - warning message on update-core.php
-----------------------------+-----------------------
 Reporter:  harmr            |       Owner:
     Type:  defect (bug)     |      Status:  reopened
 Priority:  normal           |   Milestone:  3.7
Component:  Upgrade/Install  |     Version:  trunk
 Severity:  major            |  Resolution:
 Keywords:                   |
-----------------------------+-----------------------

Comment (by nacin):

 Four possible patches.

  1. [attachment:25572.diff] actually tries to catch is_dir() warnings. The
 `ini_set('open_basedir', '/Users/nacin/Sites/develop/build/');` line is
 debug code. Only tested for open_basedir, not safe_mode.

  2. [attachment:25572.2.diff] simply @'s is_dir().

  3. [attachment:25572.3.diff] @'s the main dir we're checking (inside of
 which we're looking for .svn, etc.) and breaks if we can't access it. A
 continue isn't needed as the next directory is only going to be further
 up. Leaning toward this one even though it would be an extra directory
 call.

  4. But at this point we could switch to scandir(), since we need to check
 inside each directory for 4 directories anyway. So, that'd be
 [attachment:25572.4.diff]. but I don't actually know how performant that'd
 be, especially if directories above us are large.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25572#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software