[wp-trac] [WordPress Trac] #25540: Twenty Fourteen: Remove Header Text Color Customization Option

[WordPress Trac]

#25540: Twenty Fourteen: Remove Header Text Color Customization Option
------------------------------+------------------
 Reporter:  celloexpressions  |       Owner:
     Type:  enhancement       |      Status:  new
 Priority:  normal            |   Milestone:  3.8
Component:  Bundled Theme     |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  2nd-opinion       |
------------------------------+------------------

Comment (by celloexpressions):

 After digging around in core, it looks like adding support for not showing
 the color option is tricky. The whole custom header/custom background
 implementation is... messy. (For the record, I was thinking we could add
 the ability to disable the text color by setting the default to `'none'`,
 or something along those lines. But then we'd also need to deal with back-
 compatibility in the theme, and the alternate solution is much more
 elegant.)

 However, given the UI mess surrounding the custom header page, I don't
 think there's much benefit to worrying about hiding the color option
 there. Hopefully we can ditch that whole screen soon anyway (#25571).

 Where it really matters, especially if the separate page is eventually
 gone, it the customizer. And that's where having an almost useless option
 next to (and before) two really powerful options is particularly
 offensive.

 '''I think our best option is actually to just remove the control from the
 customizer'''. Since we're already modifying other existing controls, this
 is actually completely acceptable as the recommended/default-theme way to
 hide unneeded controls from the customizer. After all, this is kind of the
 point of having the `remove_control` function. (As an aside, this would
 also further showcase the customizer in Twenty Fourteen since we'd
 demonstrate adding controls, removing them, and modifying existing ones.)

 I'm adding a patch that removes the control from the customizer. I
 honestly don't care about the Custom Header page, and don't think many
 users spend much time there, especially if they didn't use WordPress much
 before 3.4 (ie, newer users are increasingly more likely to use the
 customizer as much as possible as it becomes more prominent).

 If we do decide to keep this control around, we should at least add
 postMessage support to it, like the background color has (though this
 isn't as realistic for the accent color, unfortunately).

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25540#comment:6>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software