[wp-trac] [WordPress Trac] #25325: Twenty Fourteen: Allow pages to have featured images

[WordPress Trac]

#25325: Twenty Fourteen: Allow pages to have featured images
-------------------------------------+---------------------------
 Reporter:  iamtakashi               |       Owner:  lancewillett
     Type:  enhancement              |      Status:  reopened
 Priority:  normal                   |   Milestone:  3.8
Component:  Bundled Theme            |     Version:  trunk
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-refresh  |
-------------------------------------+---------------------------

Comment (by iamtakashi):

 Replying to [comment:17 lancewillett]:
 > I noticed in testing that this wasn't working quite right -- the link
 should appear only on index, and not in single. And we shouldn't check for
 {{{has_post_thumbnail()}}} at all, right? Otherwise the background pattern
 won't ever show up.

 Good catch. You're right. that's also why the placeholder was clickable in
 in single.
 >
 > Also noting that in the a11y ticket, see
 http://core.trac.wordpress.org/ticket/25054#comment:31 -- this came up as
 a possible problem for screen readers if the div or anchor element is
 empty. Could we add a fallback text or something for when no image exists,
 and hide it with {{{.screen-reader-text}}} maybe?

 OK, but what would be the appropriate text? Something like "No Featured
 Image"?

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25325#comment:18>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software